Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for parallel runs with multisegment wells that have shut perforations #6104

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lisajulia
Copy link
Contributor

@lisajulia lisajulia commented Mar 25, 2025

This PR fixes parallel runs with multisegment wells that have SHUT perforations.
The test added in the last commit of this PR fails without the changes before (#6139).

In order to address such simulations, I've changed the behavior when accessing structures that work with only the OPEN perforations, like std::vector<std::vector> perforations_ of MultisegmentWellSegments.
For this, I've added the construction of a activeToLocal map in the function WellState::initWellStateMSWell and then added this map and its conteraprt localToActive to the ParallelWellInfo class.

@lisajulia lisajulia marked this pull request as draft March 25, 2025 10:18
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@bska
Copy link
Member

bska commented Mar 25, 2025

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from 998a1e9 to dab5bcd Compare March 25, 2025 12:37
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from dab5bcd to c27cb32 Compare March 25, 2025 15:26
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from c27cb32 to 1ca53fd Compare March 26, 2025 10:40
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from 1ca53fd to 1900d42 Compare March 26, 2025 11:02
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from 1900d42 to b85f25b Compare March 31, 2025 08:05
…Well_impl

With this change, parallel cases where one rank contains only SHUT perforations can be run
…ultisegmentWell_impl for parallel runs with MSWells where one rank contains only shut perforations
@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from b85f25b to 506b474 Compare April 1, 2025 07:59
…ation on a rank

Before, when the local_indices_ object was empty, a sequential run was assumed, yet that can also mean that there are no local_indices_ on this rank.
Now, a sequential run is assumed only if the size of the communiator is 1.
@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch 2 times, most recently from 28cd763 to 170bce3 Compare April 3, 2025 07:14
@lisajulia lisajulia marked this pull request as ready for review April 3, 2025 07:16
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia changed the title Changes for parallel runs with multisegment wells that have just shut perforations on one rank Changes for parallel runs with multisegment wells that have shut perforations Apr 3, 2025
@lisajulia lisajulia marked this pull request as draft April 3, 2025 07:34
This is needed for cases with SHUT perforations, since the structure std::vector<std::vector<int>> perforations_ of MultisegmentWellSegments works with only OPEN perforations
@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from 170bce3 to 7c8f100 Compare April 3, 2025 07:36
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia force-pushed the feature/ms-wells-shut-perforations branch from 7c8f100 to 5f826b2 Compare April 3, 2025 08:48
@lisajulia
Copy link
Contributor Author

jenkins build this opm-tests=1310 please

@lisajulia lisajulia marked this pull request as ready for review April 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants