output: Add linktype name #12772
Open
output: Add linktype name #12772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 6954 Add Rust based logic that maintains a hash map of link type values and their associated output names.
Use the hasmap to gather linktype display names. Issue: 6954
Issue: 6954 This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name
jlucovsky
requested review from
jasonish,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12772 +/- ##
==========================================
- Coverage 80.87% 80.86% -0.01%
==========================================
Files 936 938 +2
Lines 259748 259802 +54
==========================================
+ Hits 210061 210098 +37
- Misses 49687 49704 +17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline 25140 |
inashivb
reviewed
Mar 17, 2025
|
|
||
| #[no_mangle] | ||
| pub extern "C" fn SCDatalinkInit() -> *mut HashMap<i32, CString> { | ||
| let map: HashMap<i32, CString> = HashMap::new(); |
There was a problem hiding this comment.
Q: How many datalink values can we expect to insert in the HashMap?
Or rather, what encouraged the use of a HashMap here?
There was a problem hiding this comment.
I chose a hash map to store the mappings between linktype values and the name as the link type values are established values that are non-sequential. With the small number of entries (12-15), access should be o(1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12497
Issue: 6954
This commit adds the linktype name to the output stream. The name is determined from a Rust linktype-to-name function.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954
Describe changes:
Updates:
Provide values to any of the below to override the defaults.
SV_BRANCH=OISF/suricata-verify#2023