Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0] [IMP] follow up BLA-207 - add total weight / Volume #2545

Open
wants to merge 4 commits into
base: 18.0
Choose a base branch
from
Open

[18.0] [IMP] follow up BLA-207 - add total weight / Volume #2545

wants to merge 4 commits into from

Conversation

Mir028
Copy link

@Mir028 Mir028 commented Feb 5, 2025

No description provided.

legalsylvain
legalsylvain suggested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This computation will be wrong depending on the UoM of the line. you can see this PR that compute weight on sale order line :

https://github.com/OCA/sale-workflow/pull/3414/files#diff-053265b671fff7450b572699fd238c0e01828ae14e5b39101fb04af293e700b1R19-R29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legalsylvain legalsylvain legalsylvain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mir028 @legalsylvain