[18.0][MIG] purchase_order_supplierinfo_update: Migration to 18.0 #2500
Conversation
There was a problem hiding this comment.
Tested locally and working. I left a few comments to improve the code, mainly.
Additionally, please squash some of the administrative commits according to this guide
TT54247
@Tecnativa @pedrobaeza @sergio-teruel
| ("product_id", "=", line.product_id.id), | ||
| ("date_order", ">", line.date_order), | ||
| ] | ||
| if not self.env["purchase.order.line"].search(domain, limit=1): |
There was a problem hiding this comment.
I think this can be done with search_count instead of search. It's more efficient if you don't need any fields from the search result.
| if not self.env["purchase.order.line"].search(domain, limit=1): | |
| if not self.env["purchase.order.line"].search_count(domain): |
| from odoo.tests import Form, TransactionCase | ||
|
|
||
| from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT | ||
|
|
||
|
|
||
| class TestPurchaseOrderSupplierinfoUpdate(TransactionCase): |
There was a problem hiding this comment.
Please inherit from BaseCommon and remove DISABLED_MAIL_CONTEXT because it is already included in BaseCommon
| "order_line": [ | ||
| ( | ||
| 0, | ||
| 0, | ||
| { | ||
| "product_id": self.product_2.id, | ||
| "product_uom": self.product_2.uom_po_id.id, | ||
| "price_unit": 20.00, | ||
| }, | ||
| ) | ||
| ] |
There was a problem hiding this comment.
Coud you use Command.create It is more readable. Example here
| "order_line": [ | |
| ( | |
| 0, | |
| 0, | |
| { | |
| "product_id": self.product_2.id, | |
| "product_uom": self.product_2.uom_po_id.id, | |
| "price_unit": 20.00, | |
| }, | |
| ) | |
| ] | |
| "order_line": [ | |
| Command.create({ | |
| "product_id": self.product_2.id, | |
| "product_uom": self.product_2.uom_po_id.id, | |
| "price_unit": 20.00, | |
| }) | |
| ] |
There was a problem hiding this comment.
Functional ok
Waiting for @carlos-lopez-tecnativa's comments to be resolved
|
ping @jdidderen-nsi could you please check my previous comment |
Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_supplierinfo_update Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_supplierinfo_update/pt_BR/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_order_supplierinfo_update Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_order_supplierinfo_update/it/
jdidderen
force-pushed
the
18.0-mig-purchase_order_supplierinfo_update
branch
from
9c7b66a to
1ddcc9d
Compare
|
@carlos-lopez-tecnativa We should be good to go |
| if new_seller_price != seller.price: | ||
| seller.sudo().price = new_seller_price |
There was a problem hiding this comment.
Now that Odoo supports discounts, I think it's necessary to update the discount on supplier info when it changes, similar to how the supplier info is created upon order confirmation. What do you think @sergio-teruel?
https://github.com/odoo/odoo/blob/b0c9d6c36c8c6c68e6c0fdf42dab1723744f0508/addons/purchase/models/purchase_order.py#L559
There was a problem hiding this comment.
Yes!!... I agree with @carlos-lopez-tecnativa
There was a problem hiding this comment.
@carlos-lopez-tecnativa @sergio-teruel The discount is added in the logic. I applied all the comments in 17.0 too #2499 👍
jdidderen
force-pushed
the
18.0-mig-purchase_order_supplierinfo_update
branch
from
0f81d1a to
32f12f1
Compare
jdidderen
force-pushed
the
18.0-mig-purchase_order_supplierinfo_update
branch
from
32f12f1 to
b577ab5
Compare
| if vals.get("price_unit"): | ||
| self.update_supplierinfo_price() |
There was a problem hiding this comment.
In a confirmed purchase order, if you change the prices, it will update the supplier_info. It is also possible to evaluate the discount.
| if vals.get("price_unit"): | |
| self.update_supplierinfo_price() | |
| if vals.get("price_unit") or "discount" in vals: | |
| self.update_supplierinfo_price() |
| @@ -0,0 +1,5 @@ | |||
| This module extends the functionality of purchase to allow the price of | |||
There was a problem hiding this comment.
I think it needs to be updated in the README to mention that the discount will be updated too.
No description provided.