[16.0][IMP] purchase_request + purchase_request_type: Misc changes (hide company_id field + set groups to group_id field) #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
3 times, most recently
from
93cd5f4 to
357c542
Compare
gbrito
suggested changes
Oct 25, 2024
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
357c542 to
87eb11a
Compare
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
f06a2ea to
ebdc9fd
Compare
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
8dfb9af to
1b0f77f
Compare
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
1b0f77f to
aab262b
Compare
victoralmau
changed the title
|
Locked by purchase_triple_discount #2579 (comment) Finally the change of the approver has been removed because the focus is changed to Please @carlos-lopez-tecnativa can you review it? |
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
cc27604 to
af2d130
Compare
victoralmau
changed the title
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
3 times, most recently
from
681342d to
d668e22
Compare
pedrobaeza
requested changes
Mar 10, 2025
purchase_request_tier_validation/data/purchase_request_tier_definition.xml
Outdated
Show resolved
Hide resolved
| @@ -74,6 +74,7 @@ def test_compute_purchase_request_type(self): | |||
| self.assertEqual(request2.reduce_step, self.type2.reduce_step) | |||
|
|
|||
| def test_purchase_request_type_company_error(self): | |||
| self.type1.company_id = self.env.company | |||
There was a problem hiding this comment.
This sounds weird if you need to assign the company explicitly. Isn't this revealing a problem?
There was a problem hiding this comment.
That's right, the data tier.definition has no company_id defined and this test is intended to check what happens if a tier.definition has company_id defined but, again, if you want this to work differently comment it and I will modify it.
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
af5c41c to
71b5ad5
Compare
Add the company_id field always to avoid errors if a domain needs it. TT55213
… when you have Multi-company permission) TT55213
…hived filter TT55213
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
71b5ad5 to
d95f44a
Compare
…pty in the definition TT55213
…invalidate_cache() to invalidate_model() to avoid warning log Change the method to invalidate_model() to avoid the error: WARNING devel py.warnings: /opt/odoo/auto/addons/purchase_product_packaging_container_deposit/tests/test_purchase_product_packaging_container_deposit.py:277: DeprecationWarning: Deprecated method invalidate_cache(), use invalidate_model(), invalidate_recordset() or env.invalidate_all() instead
Change the Environment.manage() method to avoid the warning log: WARNING odoo py.warnings: /usr/lib/python3.10/contextlib.py:135: DeprecationWarning: Since Odoo 15.0, Environment.manage() is useless.
…o demo data TT55213
victoralmau
force-pushed
the
16.0-imp-purchase_request-TT51248
branch
from
d95f44a to
92e7b88
Compare
pedrobaeza
approved these changes
Mar 12, 2025
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at fb40987. Thanks a lot for contributing to OCA. ❤️ |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done:
purchase_request: Hide thecompany_idfield from the lines + add index.purchase_request: Set groups togroup_idfieldpurchase_request: Add company_id field (invisible) to form view.purchase_request_type: Show request_type field always (not only when you have Multi-company permission.purchase_request_type: Leave the company_id field empty.purchase_request: Leave the company_id field empty in the sequence.purchase_request_tier_validation: Leave the company_id field empty in the definition.purchase_order_uninvoiced_amount: Avoid warning log.purchase_product_packaging_container_deposit: Change method toinvalidate_cache()toinvalidate_model()to avoid warning log.purchase_request_department: ChangeEnvironment.manage()method.purchase_request_tier_validation: Change tier.definition data to demo data.purchase_request_type: Change purchase.request.type data to demo data.purchase_request: Add kanban view.Changes done:
purchase_request_type: Change toggle_active to web_ribbon + Archived filter.Before
After
@Tecnativa TT51248 TT55213