[18.0][IMP] product_customerinfo: Allow searching product templates by customer info

[carlos-lopez-tecnativa]

Now, in the sale order, the product template is displayed by default. This update adds the ability to search for product templates using customer info.

Reference: odoo/odoo#155449

TT54233
@Tecnativa @pedrobaeza @victoralmau could you please review this.

[OCA-git-bot]

Hi @luisg123v,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

I think you should control the extra search by a context key activated in the sales order, and give priority to the result of product.customerinfo records. How is this handled in purchase by core?

[carlos-lopez-tecnativa]

In purchase.order, the partner_id is passed by context, similar to how it is done in sale.order.

In this module, when searching for product.product, the name_search does not expect any specific context(just partner_id). For product.template, it follows the same logic as product.product. What exactly needs to be changed? Please provide more details.

product.product

product-attribute/product_customerinfo/models/product_product.py

Lines 20 to 41 in 0f082a3

	def name_search(self, name, args=None, operator="ilike", limit=100):
	res = super().name_search(name, args=args, operator=operator, limit=limit)
	res_ids_len = len(res)
	if (
	not name
	and limit
	or not self._context.get("partner_id")
	or res_ids_len >= limit
	):
	return res
	limit -= res_ids_len
	supplier_domain = [
	("partner_id", "=", self._context.get("partner_id")),
	"|",
	("product_code", operator, name),
	("product_name", operator, name),
	]
	match_domain = [("product_tmpl_id.customer_ids", "any", supplier_domain)]
	products = self.search_fetch(
	expression.AND([args or [], match_domain]), ["display_name"], limit=limit
	)
	return res + [(product.id, product.display_name) for product in products.sudo()]

product.template
https://github.com/Tecnativa/product-attribute/blob/0b2668128d84949bff76d553e0f4d93fb7e8dfb4/product_customerinfo/models/product_template.py#L95-L96

[pedrobaeza]

OK, I see the context key. It seems enough.

[pedrobaeza]

Can part of this code reused in product.product for not duplicating it?

[carlos-lopez-tecnativa]

Can part of this code reused in product.product for not duplicating it?

Note that both name_search implementations are different in terms of the fields used: product.product relies on product_tmpl_id.customer_ids, while product.template uses customer_ids. I don’t believe it is necessary to create a new AbstractModel here. Please let me know if this solution is sufficient or if the abstract model is needed

[victoralmau]

I think this should not be product_id=false or if you define a specific record for a variant it does not work correctly, right?

[carlos-lopez-tecnativa]

When creating a record from product.product or product.template, the product_id field is always empty by default. It is only set when the user explicitly selects a variant in this field. In such cases, the customer info should be linked specifically to that variant. Therefore, from my perspective, it is correct that this record is not considered here.

[pedrobaeza]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1912-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3951d49. Thanks a lot for contributing to OCA. ❤️