[18.0][MIG] product_pricelist_revision: Migration to 18.0 #1791

BhaveshHeliconia · 2024-12-02T04:35:26Z

No description provided.

rousseldenis · 2025-01-08T12:32:16Z

/ocabot migration product_pricelist_revision

[UPD] Update product_pricelist_revision.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-12.0/product-attribute-12.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_pricelist_revision/

…t filter TT28144 [UPD] Update product_pricelist_revision.pot

Currently translated at 100.0% (30 of 30 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_pricelist_revision/ca/

Before this change on runbot we caught a Warning about deprecated call to decimal_precision.get_precision(<application>) [UPD] README.rst product_pricelist_revision 13.0.1.1.0

TT27524

Fix website key in the manifests

TT31815

Currently translated at 31.0% (9 of 29 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_pricelist_revision/it/

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/it/

- Include context keys for avoiding mail operations overhead.

Currently translated at 100.0% (29 of 29 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_pricelist_revision Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_pricelist_revision/fr/

carlos-lopez-tecnativa

Tested and working. Just a minor change to update the README. Please let me know if you have any questions.

TT54468

carlos-lopez-tecnativa · 2025-03-17T18:39:02Z

product_pricelist_revision/readme/CONFIGURE.md

+1.  Go to *Sales \> Configuration \> Settings* and check "Pricelists"
+    option and "Advanced price rules" after that.


Please update the README, as the Advanced price rules no longer exist. You just need to activate the Pricelist check.

carlos-lopez-tecnativa · 2025-03-17T18:39:19Z

product_pricelist_revision/readme/DESCRIPTION.md

@@ -0,0 +1,3 @@
+This module adds a 'Pricelist items' tree view that allows to select


Suggested change

This module adds a 'Pricelist items' tree view that allows to select

This module adds a 'Pricelist items' list view that allows to select

carlos-lopez-tecnativa · 2025-03-17T18:40:30Z

product_pricelist_revision/readme/USAGE.md

+2.  Add a Pricelist Items to that Price List. Set 'Fix Price' value on
+    the field 'Compute Price' and set a fixed price.


Suggested change

2. Add a Pricelist Items to that Price List. Set 'Fix Price' value on

the field 'Compute Price' and set a fixed price.

2. Add a Pricelist Items to that Price List. Set 'Fixed Price' value on

the field 'Price type' and set a fixed price.

carlos-lopez-tecnativa · 2025-03-17T18:42:54Z

product_pricelist_revision/tests/test_product_pricelist_revision.py

+from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+
+
+class TestProductPricelistRevision(TransactionCase):
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))


Could you please inherit from BaseCommon? and remove DISABLED_MAIL_CONTEXT

carlos-lopez-tecnativa · 2025-03-17T18:47:15Z

product_pricelist_revision/wizards/pricelist_duplicate_wizard.py

+            item.date_end = self.date_start - relativedelta(seconds=1)
+
+        xmlid = "product_pricelist_revision.product_pricelist_item_action"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)


Once the new rules are created, they show the new records, but the action has a context that activates the Current filter. If the pricelist is in the future, it can confuse the user since nothing will be displayed. Please remove this key from the context to avoid confusion.

Just here, try something like:

Suggested change

action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)

action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)

action["context"] = {}

BhaveshHeliconia · 2025-03-18T05:40:08Z

@carlos-lopez-tecnativa, Please Review.all requested changes are fixed let me know if i missed anything.Thank you!

carlos-lopez-tecnativa · 2025-03-18T10:56:19Z

product_pricelist_revision/views/pricelist_view.xml

+            ]
+        "
+        />
+        <field name="context">{}</field>


In my previous comment, I didn’t mean to always remove the context from this action. I meant to remove only the specific key, but only when the wizard reads this action. Please restore this context in the action and remove only the specific key from the wizard.

carlos-lopez-tecnativa · 2025-03-18T10:57:29Z

product_pricelist_revision/wizards/pricelist_duplicate_wizard.py

+            item.date_end = self.date_start - relativedelta(seconds=1)
+
+        xmlid = "product_pricelist_revision.product_pricelist_item_action"
+        action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)


Just here, try something like:

Suggested change

action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)

action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)

action["context"] = {}

BhaveshHeliconia · 2025-03-19T06:07:04Z

@carlos-lopez-tecnativa, Please Review.

carlos-lopez-tecnativa · 2025-03-19T11:59:10Z

product_pricelist_revision/wizards/pricelist_duplicate_wizard_view.xml

+                    Set new start date and variation percent to duplicate.
+                    This process set start date previous day as end date of
+                    origin record.


This wizard updates the new price according to variations, but only when the pricelist item is based on a fixed price. Is it possible to add a message here to clarify this behavior for the user? Currently, it is only explained in the module README. What do you think?

BhaveshHeliconia mentioned this pull request Dec 17, 2024

Migration to version 18.0 #1741

Open

44 tasks

BhaveshHeliconia force-pushed the 18.0-mig-product_pricelist_revision branch from 1245f4d to a1f6631 Compare December 27, 2024 10:28

BhaveshHeliconia force-pushed the 18.0-mig-product_pricelist_revision branch from a1f6631 to 947160c Compare January 8, 2025 11:54

OCA-git-bot added this to the 18.0 milestone Jan 8, 2025

sergio-teruel and others added 24 commits February 25, 2025 16:27

11.0[WIP]product_pricelist_revision

e45d03f

[11.0][IMP] product_pricelist_revision: Complete translations

ede8bf0

[IMP] product_pricelist_revision: black, isort

40d2152

[MIG] product_pricelist_revision: Migration to v13.0

152641f

[IMP] product_pricelist_revision: Add percent price column and curren…

9a92f10

…t filter TT28144 [UPD] Update product_pricelist_revision.pot

Added translation using Weblate (Catalan)

7d672c0

[FIX] product_pricelist_revision: Applied the new way for digits

27e51ed

Before this change on runbot we caught a Warning about deprecated call to decimal_precision.get_precision(<application>) [UPD] README.rst product_pricelist_revision 13.0.1.1.0

[IMP] product_pricelist_revision: Allow create pricelist item

5f1889d

TT27524

[IMP] *: pre-commit execution

f5e5447

Fix website key in the manifests

[MIG] product_pricelist_revision: Migration to 14.0

8142b46

TT31815

[FIX] Fix access right issues when using actions

9804189

product_pricelist_revision: fix date_end/date_start are datetime

f08d466

Added translation using Weblate (Italian)

27fdd84

[MIG] product_pricelist_revision: Migration to 15.0

c18ef6a

[MIG] product_pricelist_revision: Migration to 16.0

2ac3c9a

[IMP] product_pricelist_revision: test performance improvement

4637c21

- Include context keys for avoiding mail operations overhead.

Added translation using Weblate (French)

fceb8f3

[IMP] product_pricelist_revision: pre-commit auto fixes

6f34b99

[MIG] product_pricelist_revision: Migration to 17.0

7a5c512

BhaveshHeliconia force-pushed the 18.0-mig-product_pricelist_revision branch from 947160c to d30d7fb Compare February 25, 2025 10:59

carlos-lopez-tecnativa suggested changes Mar 17, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-product_pricelist_revision branch from d30d7fb to d513073 Compare March 18, 2025 05:19

BhaveshHeliconia requested a review from carlos-lopez-tecnativa March 18, 2025 05:40

carlos-lopez-tecnativa suggested changes Mar 18, 2025

View reviewed changes

[MIG] product_pricelist_revision: Migration to 18.0

8c90201

BhaveshHeliconia force-pushed the 18.0-mig-product_pricelist_revision branch from d513073 to 8c90201 Compare March 19, 2025 05:32

carlos-lopez-tecnativa reviewed Mar 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] product_pricelist_revision: Migration to 18.0 #1791

[18.0][MIG] product_pricelist_revision: Migration to 18.0 #1791

BhaveshHeliconia commented Dec 2, 2024

rousseldenis commented Jan 8, 2025

carlos-lopez-tecnativa left a comment •

edited

Loading

carlos-lopez-tecnativa Mar 17, 2025

carlos-lopez-tecnativa Mar 17, 2025

carlos-lopez-tecnativa Mar 17, 2025

carlos-lopez-tecnativa Mar 17, 2025

carlos-lopez-tecnativa Mar 17, 2025

carlos-lopez-tecnativa Mar 18, 2025

BhaveshHeliconia commented Mar 18, 2025

carlos-lopez-tecnativa Mar 18, 2025

carlos-lopez-tecnativa Mar 18, 2025

BhaveshHeliconia commented Mar 19, 2025

carlos-lopez-tecnativa Mar 19, 2025

		1. Go to Sales \> Configuration \> Settings and check "Pricelists"
		option and "Advanced price rules" after that.

		@@ -0,0 +1,3 @@
		This module adds a 'Pricelist items' tree view that allows to select

	This module adds a 'Pricelist items' tree view that allows to select
	This module adds a 'Pricelist items' list view that allows to select

		2. Add a Pricelist Items to that Price List. Set 'Fix Price' value on
		the field 'Compute Price' and set a fixed price.

	action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
	action = self.env["ir.actions.act_window"]._for_xml_id(xmlid)
	action["context"] = {}

[18.0][MIG] product_pricelist_revision: Migration to 18.0 #1791

Are you sure you want to change the base?

[18.0][MIG] product_pricelist_revision: Migration to 18.0 #1791

Conversation

BhaveshHeliconia commented Dec 2, 2024

rousseldenis commented Jan 8, 2025

carlos-lopez-tecnativa left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BhaveshHeliconia commented Mar 18, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BhaveshHeliconia commented Mar 19, 2025

Choose a reason for hiding this comment

carlos-lopez-tecnativa left a comment •

edited

Loading