Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_th_base_sequence: Migration to 17.0 #504

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

baptiste-n42
Copy link

@baptiste-n42 baptiste-n42 commented Jan 27, 2025

  • Removed the ir_sequence_date_range._get_number_next_actual and ir_sequence_date_range._next method as it seems to not be required on Odoo 17.
  • Ensure preview is recomputed on ir.sequence.date_range when the parent ir.sequence's use_date_range is modified.

Notes regarding the preview feature :

Saran440 and others added 2 commits January 27, 2025 14:19
- Rename module name l10n_th_sequence_refactored to l10n_th_base_sequence
- Combine 4 module into l10n_th_base_sequence
    - l10n_th_sequence_refactored
    - l10n_th_sequence_range_date
    - l10n_th_sequence_qoy
    - l10n_th_sequence_be
@Saran440
Copy link
Member

/ocabot migration l10n_th_base_sequence

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 28, 2025
10 tasks
@baptiste-n42 baptiste-n42 marked this pull request as ready for review February 10, 2025 16:01
@baptiste-n42 baptiste-n42 force-pushed the 17.0-mig-l10n_th_base_sequence branch 3 times, most recently from 45844fb to ca2c517 Compare February 13, 2025 06:54
@@ -17,21 +15,3 @@ def _compute_preview(self):
ir_sequence_date_range=record.date_from,
ir_sequence_date_range_end=record.date_to,
).sequence_id.get_next_char(record.number_next_actual)

def _next(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baptiste-n42 This feature can't delete because we add feature %(range_end_y)s

Example:

For Thai Goverment has budget period start 01 Oct and end of period is 30 Sep next year

  • 01 Oct 2024 - 30 Sep 2025
    Selection_008

If we config sequence show year. and we create document on 10 Oct 2024, it should show 2025 or 25

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I got it now! Thanks

@baptiste-n42 baptiste-n42 force-pushed the 17.0-mig-l10n_th_base_sequence branch from ca2c517 to faf0e61 Compare February 19, 2025 11:46
baptiste-n42 and others added 3 commits February 19, 2025 18:48
* Ensure preview is recomputed on `ir.sequence.date_range` when the parent `ir.sequence.use_date_range` is modified.
* Enable preview computation for multiple sequences (potentially allowing display in list view).

Notes:

* The preview feature might be better suited for another module, ideally in the Odoo base branch.
* This aligns with the intent of PR odoo/odoo#100847, though it was canceled.
@baptiste-n42 baptiste-n42 force-pushed the 17.0-mig-l10n_th_base_sequence branch from faf0e61 to 16479da Compare February 19, 2025 11:50
@baptiste-n42
Copy link
Author

I don't understand how you passed the codecov in #466 @Saran440

@Saran440
Copy link
Member

If you need green codecov, you must add test script cover code 98.03%. Now it 94.44%

However, Test script is not required to green. if other approve this 2 person. we can merge.

Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Reviewed 👍

Copy link
Member

@TheerayutEncoder TheerayutEncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Saran440
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-504-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79cd297. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit b815bed into OCA:17.0 Feb 25, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants