-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] l10n_th_base_sequence: Migration to 17.0 #504
[17.0][MIG] l10n_th_base_sequence: Migration to 17.0 #504
Conversation
- Rename module name l10n_th_sequence_refactored to l10n_th_base_sequence - Combine 4 module into l10n_th_base_sequence - l10n_th_sequence_refactored - l10n_th_sequence_range_date - l10n_th_sequence_qoy - l10n_th_sequence_be
/ocabot migration l10n_th_base_sequence |
45844fb
to
ca2c517
Compare
@@ -17,21 +15,3 @@ def _compute_preview(self): | |||
ir_sequence_date_range=record.date_from, | |||
ir_sequence_date_range_end=record.date_to, | |||
).sequence_id.get_next_char(record.number_next_actual) | |||
|
|||
def _next(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baptiste-n42 This feature can't delete because we add feature %(range_end_y)s
Example:
For Thai Goverment has budget period start 01 Oct and end of period is 30 Sep next year
If we config sequence show year. and we create document on 10 Oct 2024, it should show 2025
or 25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I got it now! Thanks
ca2c517
to
faf0e61
Compare
* Ensure preview is recomputed on `ir.sequence.date_range` when the parent `ir.sequence.use_date_range` is modified. * Enable preview computation for multiple sequences (potentially allowing display in list view). Notes: * The preview feature might be better suited for another module, ideally in the Odoo base branch. * This aligns with the intent of PR odoo/odoo#100847, though it was canceled.
faf0e61
to
16479da
Compare
If you need green codecov, you must add test script cover code 98.03%. Now it 94.44% However, Test script is not required to green. if other approve this 2 person. we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Reviewed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 79cd297. Thanks a lot for contributing to OCA. ❤️ |
Removed their_sequence_date_range._get_number_next_actual
andir_sequence_date_range._next
method as it seems to not be required on Odoo 17.ir.sequence.date_range
when the parentir.sequence
'suse_date_range
is modified.Notes regarding the
preview
feature :