[17.0][FIX] base_import_pdf_by_template: Don't fail on fetchmail #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @victoralmau, |
If you have a bad formatted PDF that comes from the mail, the cron process may fail trying to parse it, and block the whole fetching indefinitely. Let's avoid the crash masking it behind the existing context key. TT55481
pedrobaeza
force-pushed
the
17.0-fix-base_import_pdf_by_template
branch
from
c7ac5fa to
673e640
Compare
victoralmau
approved these changes
Mar 17, 2025
carlos-lopez-tecnativa
approved these changes
Mar 17, 2025
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 30cd356. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a bad formatted PDF that comes from the mail, the cron process may fail trying to parse it, and block the whole fetching indefinitely.
Let's avoid the crash masking it behind the existing context key.
@Tecnativa TT55481