Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] website_sale_slides_order_line_link: Add new module #8

Merged

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Mar 6, 2025

@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review March 6, 2025 06:56
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-website_sale_slides_order_line_link branch from 87ac559 to 39522d7 Compare March 6, 2025 07:00
@pedrobaeza pedrobaeza added this to the 15.0 milestone Mar 6, 2025
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: This module does not add any views or filters. Is it intended as a glue module for another purpose? Could you provide more information or context to better understand its function?

@chienandalu
Copy link
Member

Code review: This module does not add any views or filters. Is it intended as a glue module for another purpose? Could you provide more information or context to better understand its function?

Is indeed a technical module, splitting pulling a functionality from this other work #6 that might be common for other future modules

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-website_sale_slides_order_line_link branch from 39522d7 to a75f612 Compare March 13, 2025 07:16
@pilarvargas-tecnativa
Copy link
Author

Code review: This module does not add any views or filters. Is it intended as a glue module for another purpose? Could you provide more information or context to better understand its function?

I have added the information to the module to make it a little less confusing.

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-website_sale_slides_order_line_link branch from a75f612 to 97cbb43 Compare March 13, 2025 15:26
TT54986
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 15.0-add-website_sale_slides_order_line_link branch from 97cbb43 to f501e10 Compare March 13, 2025 16:20
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-8-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 05d66d9. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 41a557d into OCA:15.0 Mar 13, 2025
7 checks passed
@pedrobaeza pedrobaeza deleted the 15.0-add-website_sale_slides_order_line_link branch March 13, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants