[18.0][MIG] account_credit_control: Migration to version 18.0 #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration account_credit_control |
|
The migration issue (#401) has not been updated to reference the current pull request because a previous pull request (#418) is not closed. |
|
/ocabot migration account_credit_control |
|
Please, cherry-pick #438 to commit history (before migration commit). |
|
@victoralmau Just curious, but does the order of the commits matter? |
IMO there are several reasons:
|
* Modify scenarios to be compatible with python scenarios * Voucher/statement related steps * Deprecated step implementation * Print report generation * All tests green * Mail + print of reminder * Broken translations
* Fix failure to confirm invoice when both account_credit_control and account_constraints are installed * use except_orm instead of except_osv * reindent code * Cleanup * use of deprecated field user_email causes permission error in multicompany setting fixed by using the correct 'email' field in the template
* Address in mako template to make sure address is displayed * Remove 'more info here' from report * Add some css to reminder report and set texts taking the whole width of the document * Add a subject in reminder report
* Report use precise mode by default * date_entry fields on line model to be used by report or in next MP on filter group by * reporting layer, + add hook function to get contact address * credit control mail are not in plain text but send as attachement * policy level name is now translatable as it is use in report and mail * permission on invoices because onetomany widget load data even if hidden ... * translation files + lang source * french translation
* Translation + report invoice address layout * Label Force credit control policy + french translation
…when partners or accounts are duplicated
…e in non draft state before deleting it
* pep8 (space after comma, reduced length of lines) * does not need to check if there is ids before calling unlink, it will return early * remove unused import * 'raise a new invoice' is a British English expression for 'issue a new invoice'
…ranslation extraction
* scenarios: We fix year of scenario on 2013 to have reproducable setup, and ensure test maintnability. The credit control scenarios are based on base_finance setup scenario provided in the project OpenERP Scenarios. This setup provide a financial setup for 2012 2013. We also fix some value as precision computation has been improved in OpenERP. * bug 1287072 Level calculation error if previous credit line is ignored * unifing wizard views to respect UI guide lines * credit control policy changer. Add a wizard on Invoice that will add a credit line and deprecate exisiting one on the invoice * test to ensure that wizard run on customer invoice * Scenario that test coherence of credit run after manually altering an invoice level * multicurrency in communication * ...
…ding _unported suffix
* Partner Form view: field "credit_limit" is defined in account module, not base * Minimal Danish translation * Do not link e-mails to Transient records Transient records are deleted periodically so res_id will point to ID which does not exists. And when reading email records system would also check if res_id can be read by user which would cause an exception because res_id might not exist at that point.
This fix seems ugly, but I cant figure why I've a security error when an invoice is displayed for a user without right on credit_control despite the attribute 'groups' declared on the field definition in the form view
…ntrol mail template
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
Currently translated at 100.0% (282 of 282 strings) Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/es/
…eporting This fixes the layout of the 'Credit Control Policy' notebook-page 'Mail and reporting'. Several related labels and fields not aligned (not on same line) and also the translation buttons are invisible.
- Create setUpClass method if necessary - Include context keys for avoiding mail operations overhead.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-16.0/credit-control-16.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-16-0/credit-control-16-0-account_credit_control/
…rs without "Credit Control/Info" access @moduon MT-4827
The method _generate_emails sets the credit.control.line record(s) with state 'to_be_sent' to state 'queued' after sending the mail(s), which is not right. The state 'queued' is now set (from 'to_be_sent') before sending the emails! The mail.mail _postprocess_sent_message method sets the final state to 'sent' or 'error'.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/
Currently translated at 100.0% (278 of 278 strings) Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/it/
Before this commit, the existing code was obsolete because, in V17, the body field is computed, and _onchange_template_id no longer exists. This commit adapts the code to correctly include invoice details in the email body.
…mail template When a user with the group_account_credit_control_manager group tries to select a mail template, an access error is raised because model_id has permissions restricted to Administration/Access Rights. Instead of using a many2one field, the model field is used, as it is related and stored.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/
…the maximum level for one control run Some ux improvements and minor fixes
Currently translated at 100.0% (280 of 280 strings) Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/it/
…to auto-subscribe in credit control lines TT55207
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/
Currently translated at 100.0% (281 of 281 strings) Translation: credit-control-17.0/credit-control-17.0-account_credit_control Translate-URL: https://translation.odoo-community.org/projects/credit-control-17-0/credit-control-17-0-account_credit_control/it/
…ation email Changes done: - Defined date_entry for the Invoice date column. - Define amount_due for Invoice amount column - Set balance_due for the Amount Due column This data is the same as already shown in the Credit Control Summary report. TT55608
… number for moves TT55608
…nd in the report for correct visualization TT55608
carlos-lopez-tecnativa
force-pushed
the
18.0-mig-account_credit_control
branch
from
e880b63 to
f268c6d
Compare
Done |
| <field name="global" eval="True" /> | ||
| <field | ||
| name="domain_force" | ||
| >['|',('company_id','=',False),('company_id','in',company_ids)]</field> |
There was a problem hiding this comment.
This should be better for performance (here and further below).
Suggested change
| >['|',('company_id','=',False),('company_id','in',company_ids)]</field> | |
| >['|', ('company_id','in',company_ids + [False])]</field> |
| @@ -270,7 +271,7 @@ def _generate_policy_lines_with_max_level( | |||
| return policy_lines_generated | |||
|
|
|||
| @api.model | |||
| def _name_search(self, name, domain=None, operator="ilike", limit=None, order=None): | |||
| def _search_display_name(self, operator, value): | |||
There was a problem hiding this comment.
Maybe a test, given that the change went unnoticed on the original PR because there was no test before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #418
TT54066
@Tecnativa @pedrobaeza @sergio-teruel @victoralmau @StefanRijnhart could you please review this?