[17.0][MIG] account_invoice_fiscal_position_update: Migration to 17.0 #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, tax mapping could be wrong set
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/nl_NL/
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_fiscal_position_update/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/nl/
Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_fiscal_position_update/es/
…xes after changed
…s without comments or notes.
… taxes when this was changed. Otherwise the taxes are not changed when change the fpos.
Don't create new variant, just use the default one.
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/hr/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/es/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_fiscal_position_update/pt_BR/
…fiscal position with a line without product and description
Fixes OCA#1896 This change causes the subtotal amount to remain the same when a fiscal position change triggers a tax update from tax included in price to tax excluded from price. Tests are added for conversion between tax excluded to tax included as well, but in this case the behaviour is not 'fixed'. The standard behaviour of Odoo in case of tax excl. to tax incl. is to adjust the subtotal amount. The same behaviour is present in the function that this module provides. It might not be what users expect, but it seems that Odoo does not support to preserve the subtotal amount in this case.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-18.0/account-invoicing-18.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-18-0/account-invoicing-18-0-account_invoice_fiscal_position_update/
Currently translated at 100.0% (6 of 6 strings) Translation: account-invoicing-18.0/account-invoicing-18.0-account_invoice_fiscal_position_update Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-18-0/account-invoicing-18-0-account_invoice_fiscal_position_update/it/
carlos-lopez-tecnativa
approved these changes
Mar 5, 2025
|
/ocabot migration account_invoice_fiscal_position_update |
|
This PR looks fantastic, let's merge it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1935-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Hey, wait, have you considered the new button for doing that?:
I think this module is no longer needed. Do you agree, @StefanRijnhart ? |
|
@pedrobaeza i dont know how i overlooked this... i think this module is obsolete odoo/odoo@c54851b |
|
Then you should mark this module as merged in OpenUpgrade in this file: https://github.com/OCA/OpenUpgrade/blob/17.0/openupgrade_scripts/apriori.py#L17 I close this PR and comment in the migration issue. |
@pedrobaeza Should i simply open a PR towards that file? what are the conventions or documentation for this procedure? i can't find an example |
|
Example: OCA/OpenUpgrade#4752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #1630
@Tecnativa TT52311
@carlos-lopez-tecnativa @CarlosRoca13