Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][OU-ADD] sms: Nothing to do #4622

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[17.0][OU-ADD] sms: Nothing to do #4622

merged 1 commit into from
Dec 9, 2024

Conversation

acpMicrocom
Copy link
Contributor

No description provided.

@legalsylvain
Copy link
Contributor

legalsylvain commented Oct 24, 2024 •
edited
Loading

/ocabot migration sms

Depends on :

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 24, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 24, 2024
Open
rvalyi
rvalyi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@rvalyi rvalyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change indeed; tests probably fail because of one of the dependencies not migrated yet.

This was referenced Oct 24, 2024
Open
Merged
@legalsylvain legalsylvain mentioned this pull request Oct 24, 2024
Merged
@hbrunn
Copy link
Member

hbrunn commented Dec 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 9, 2024
@OCA-git-bot
Merge PR #4622 into 17.0
2822d05 
Signed-off-by hbrunn
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot
Copy link
Contributor

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member

hbrunn commented Dec 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-4622-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 70a34b3. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 70a34b3 into OCA:17.0 Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@hbrunn hbrunn hbrunn approved these changes

Assignees
No one assigned
Labels
approved Blocked by dependency merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@acpMicrocom @legalsylvain @hbrunn @OCA-git-bot @rvalyi