set executable filename for Linux #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStolk
requested changes
Nov 1, 2024
| #if WINDOWS | ||
| string ddExe = Path.Combine(UserSettings.Model.DevilDaggersInstallationDirectory, "dd.exe"); | ||
| #elif LINUX | ||
| string ddExe = Path.Combine(UserSettings.Model.DevilDaggersInstallationDirectory, "devildaggers"); | ||
| #endif | ||
| if (!File.Exists(ddExe)) |
There was a problem hiding this comment.
Perhaps we should include a default case, or not perform this check when WINDOWS and LINUX are both undefined. The build will fail otherwise and we might get a Mac build in the future.
| @@ -33,7 +33,7 @@ public static void Render() | |||
| ImGui.Spacing(); | |||
| ImGuiImage.Image(gemOrHomingTexture.Id, new Vector2(16), tintColor); | |||
| ImGui.SameLine(); | |||
| ImGui.InputInt("Added gems", ref PracticeLogic.State.AdditionalGems, 1); | |||
| ImGui.InputInt((PracticeLogic.State.HandLevel is HandLevel.Level2)? Inline.Span($"Added gems({PracticeLogic.State.AdditionalGems+10})") : "Added gems", ref PracticeLogic.State.AdditionalGems, 1); | |||
There was a problem hiding this comment.
Could you open an issue for this? I'm thinking there's probably a better way to make this more clear. I'd also prefer commits/PRs with a single purpose.
Also I'll be refactoring all of the UI soon, so I'm postponing UI changes until then because it'll be a big change.
| #if WINDOWS | ||
| string ddExe = Path.Combine(UserSettings.Model.DevilDaggersInstallationDirectory, "dd.exe"); | ||
| #elif LINUX | ||
| string ddExe = Path.Combine(UserSettings.Model.DevilDaggersInstallationDirectory, "devildaggers"); |
There was a problem hiding this comment.
Thanks! Do you know if this differs between distros? I thought it was sometimes called devildaggers.bin but not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.