Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libutil: Fix error message #12758

Merged
merged 1 commit into from
Mar 28, 2025
Merged

libutil: Fix error message #12758

merged 1 commit into from
Mar 28, 2025

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 26, 2025

I encountered this with a misconfigured libutil. I doubt that a non-lutimes config is viable, because tests were failing.

EDIT: I get the misconfiguration reproducibly with .#native-clangStdenv; need to look into why it happens
EDIT: nix build .#nix-everything-clangStdenv passes with this PR

Motivation

Context


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

I encountered this with a misconfigured libutil. I doubt that a
non-lutimes config is viable, because tests were failing.
@roberth roberth requested a review from edolstra as a code owner March 26, 2025 09:17
@roberth roberth marked this pull request as draft March 26, 2025 10:59
@edolstra
Copy link
Member

Was this intended to be a draft?

@roberth roberth marked this pull request as ready for review March 28, 2025 11:10
@roberth
Copy link
Member Author

roberth commented Mar 28, 2025

I marked it as draft by mistake because I didn't solve my root cause yet, but this PR only fixes a technically unrelated problem anyway. A possible outcome is that we remove this code, but other than that, this trivial PR is ready for review.

@Ericson2314 Ericson2314 added backport 2.24-maintenance Automatically creates a PR against the branch backport 2.26-maintenance Automatically creates a PR against the branch backport 2.27-maintenance Automatically creates a PR against the branch labels Mar 28, 2025
@Ericson2314 Ericson2314 merged commit fd98f30 into NixOS:master Mar 28, 2025
16 checks passed
mergify bot added a commit that referenced this pull request Mar 28, 2025
mergify bot added a commit that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24-maintenance Automatically creates a PR against the branch backport 2.26-maintenance Automatically creates a PR against the branch backport 2.27-maintenance Automatically creates a PR against the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants