회원가입 완료페이지, 너가소개서 결과페이지 구현 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/assets/icons/index.ts
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
SeojinSeojin
requested changes
Jan 17, 2022
|
|
||
| useEffect(() => { | ||
| (async () => { | ||
| const data = await api.neogaService.getResultTemplates(); |
There was a problem hiding this comment.
이친구의 이름을 getResultKeywords 로 바꾸어주세요1!
Comment on lines
79
to
84
| {!lookMoreButton ? ( | ||
| <ImmutableKeywordList | ||
| keywordList={resultKeywordList.slice(0, 7)} | ||
| onItemClick={() => null} | ||
| /> | ||
| ) : null} |
There was a problem hiding this comment.
Suggested change
| {!lookMoreButton ? ( | |
| <ImmutableKeywordList | |
| keywordList={resultKeywordList.slice(0, 7)} | |
| onItemClick={() => null} | |
| /> | |
| ) : null} | |
| {!lookMoreButton && ( | |
| <ImmutableKeywordList | |
| keywordList={resultKeywordList.slice(0, 7)} | |
| onItemClick={() => null} | |
| /> | |
| ) |
| </StFeedTitle> | ||
| {resultList.map((data) => { | ||
| return ( | ||
| <> |
|
|
||
| function FormDetail() { | ||
| return ( | ||
| <> |
|
|
||
| function joinComplete() { | ||
| return ( | ||
| <div> |
|
|
||
| function NeogaRouter() { | ||
| return ( | ||
| <Routes> | ||
| <Route path="/create" element={<NeogaCreate />} /> | ||
| <Route path="/detail/form" element={<FormDetail />} /> |
There was a problem hiding this comment.
/:formID/detail/form 으로 바꾸면 좋을 것 같ㅇ아ㅛ1
src/infrastructure/api/neoga.ts
Outdated
Comment on lines
5
to
6
| getResultTemplates(): Promise<Keywordlists[]>; | ||
| getAllResultListTemplates(): Promise<ResultFormList[]>; |
There was a problem hiding this comment.
ㅇ 친구들 모두 formId를 받아야 할 것 같아요(type은 Number)
# Conflicts: # src/assets/icons/index.ts # src/presentation/routes/NeogaRouter.tsx
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
SeojinSeojin
approved these changes
Jan 17, 2022
100Gyeon
approved these changes
Jan 17, 2022
NamJwong
approved these changes
Jan 17, 2022
| @@ -6,3 +6,18 @@ export type NeogaCardItem = { | |||
| src: string; | |||
| backgroundColor: string; | |||
| }; | |||
|
|
|||
| export type Keywordlists = { | |||
There was a problem hiding this comment.
요거 왜 List 아닌지 궁그매요 별 이유 없다면 나중에 수정 부탁스!
|
|
||
| function joinComplete() { | ||
| return ( | ||
| <JoinCompleteForm /> |
There was a problem hiding this comment.
혹시 요기는 JoinCompleteForm 컴포넌트가 꼭 이렇게 감싸져야 하나요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛓ Related Issues
📋 작업 내용
📌 PR Point
👀 스크린샷 / GIF / 링크