Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

랜딩페이지 리펙토링 #153

Merged
merged 5 commits into from
Jan 21, 2022
Merged

랜딩페이지 리펙토링 #153

merged 5 commits into from
Jan 21, 2022

Conversation

Hyoin-Kim
Copy link
Member

@Hyoin-Kim Hyoin-Kim commented Jan 21, 2022 •
edited
Loading

⛓ Related Issues

📋 작업 내용

  • 랜딩페이지 리펙토링

📌 PR Point

width 100 통일,
사진 깨짐 수정,
z-index 적용

👀 스크린샷 / GIF / 링크

@Hyoin-Kim Hyoin-Kim self-assigned this Jan 21, 2022
@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~

@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~

@Hyoin-Kim Hyoin-Kim added fix ☔️ 에러 고치기 refactor 🪐 리팩토링 labels Jan 21, 2022
@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~

SeojinSeojin
SeojinSeojin approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넘무 수고하셨어요... 💖

@Hyoin-Kim Hyoin-Kim merged commit e35fdfd into dev Jan 21, 2022
@100Gyeon 100Gyeon deleted the feat/#133 branch January 22, 2022 00:29
@100Gyeon
Copy link
Member

100Gyeon commented Feb 9, 2022 •
edited
Loading

사파리에서 svg 흐리게 보였던 문제 해결했던 방법 남겨둡니다!

  1. object 태그 사용하기
  2. object에 높은 z-index 값 적용하기

https://jkpark.me/safari/html/css/svg/frontend/2019/06/07/SVG-%EC%82%AC%ED%8C%8C%EB%A6%AC%EC%97%90%EC%84%9C-%ED%9D%90%EB%A6%AC%EA%B2%8C-%EB%B3%B4%EC%9D%B4%EB%8B%A4.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeojinSeojin SeojinSeojin SeojinSeojin approved these changes

@100Gyeon 100Gyeon 100Gyeon approved these changes

@NamJwong NamJwong NamJwong approved these changes

Assignees

@Hyoin-Kim Hyoin-Kim

Labels
fix ☔️ 에러 고치기 refactor 🪐 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

랜딩페이지 디자인 qa진행
4 participants
@Hyoin-Kim @SeojinSeojin @100Gyeon @NamJwong