Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color 상수 지정하기 #15

Merged
merged 3 commits into from
Jan 8, 2022
Merged

color 상수 지정하기 #15

merged 3 commits into from
Jan 8, 2022

Conversation

NamJwong
Copy link
Member

@NamJwong NamJwong commented Jan 8, 2022 •
edited
Loading

⛓ Related Issues

📋 작업 내용

  • color 상수 지정하기

📌 PR Point

디자이너분들이 지정해놓은 컬러 이름에서 약간의 수정을 거칠까 고민(main sub 이런 것 붙일지 말지 등등)하다가,
웬만하면 그대로 가져가는게 좋을 것 같아서 NSS 뗀 것 빼고는 똑같이 명명했습니다
혹시 다른 의견 있다면 말씀해주세요!
image

gray 색상은 graySub도 있고 gray1, gray2 등등도 있으니 유의!

@NamJwong NamJwong added the chore 🍣 기능 개발 외 부수적인 일들 label Jan 8, 2022
@NamJwong NamJwong self-assigned this Jan 8, 2022
@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~

100Gyeon
100Gyeon previously approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@100Gyeon 100Gyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 하나하나 지정하기 번거로웠을 텐데 언니가 맡아서 해줘서 고마워 !! 😊👍

SeojinSeojin
SeojinSeojin reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완전 수고 많았어..!! 번거로웠을텐데!!

이 친구들이 다 상수니까 CORAL_MAIN은 어떨까?

@NamJwong
Copy link
Member Author

NamJwong commented Jan 8, 2022

이거 하나하나 지정하기 번거로웠을 텐데 언니가 맡아서 해줘서 고마워 !! 😊👍

완전 수고 많았어..!! 번거로웠을텐데!!

이 친구들이 다 상수니까 CORAL_MAIN은 어떨까?

번거롭지 않았어 친구들아!!! ❤️

응응 난 CORAL_MAIN 이 형태도 좋을 것 같아!

Hyoin-Kim
Hyoin-Kim previously approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@Hyoin-Kim Hyoin-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꺄오,, 앞으로 너무 편해지겠다ㅜㅜ고마워

@NamJwong
Copy link
Member Author

NamJwong commented Jan 8, 2022

꺄오,, 앞으로 너무 편해지겠다ㅜㅜ고마워

@NamJwong NamJwong closed this Jan 8, 2022
@100Gyeon 100Gyeon reopened this Jan 8, 2022
@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~

@NamJwong NamJwong dismissed stale reviews from Hyoin-Kim and 100Gyeon via 27cce1e January 8, 2022 08:16
@SeojinSeojin
Copy link
Member

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~

SeojinSeojin
SeojinSeojin approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많았어~!~!🎀🎀

@NamJwong NamJwong merged commit a561aab into dev Jan 8, 2022
@NamJwong NamJwong deleted the feat/#14 branch January 8, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyoin-Kim Hyoin-Kim Hyoin-Kim approved these changes

@SeojinSeojin SeojinSeojin SeojinSeojin approved these changes

@100Gyeon 100Gyeon 100Gyeon approved these changes

Assignees

@NamJwong NamJwong

Labels
chore 🍣 기능 개발 외 부수적인 일들
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

color 상수 지정하기
4 participants
@NamJwong @SeojinSeojin @Hyoin-Kim @100Gyeon