Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrust execution_policy::on should take a stream_ref in addition to a stream #4150

Closed
brycelelbach opened this issue Mar 14, 2025 · 0 comments · Fixed by #4225
Closed

Thrust execution_policy::on should take a stream_ref in addition to a stream #4150

brycelelbach opened this issue Mar 14, 2025 · 0 comments · Fixed by #4225

Comments

@brycelelbach
Copy link
Contributor

Deletes six characters from a few lines in my slides (.get()).

In all seriousness, I'm not sure if there's any advantage to this other than convenience, but I still think it's worth doing. We want to discourage passing around raw streams, right?
@github-project-automation github-project-automation bot moved this to Todo in CCCL Mar 14, 2025
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue Mar 21, 2025
@bernhardmgruber
Allow cuda::par*.on() to take cuda::stream_ref
566668d 
Fixes: NVIDIA#4150
@bernhardmgruber bernhardmgruber mentioned this issue Mar 21, 2025
Merged
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Mar 21, 2025
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue Mar 21, 2025
@bernhardmgruber
Allow cuda::par*.on() to take cuda::stream_ref
788dcf9 
Fixes: NVIDIA#4150
bernhardmgruber added a commit to bernhardmgruber/cccl that referenced this issue Mar 21, 2025
@bernhardmgruber
Allow cuda::par*.on() to take cuda::stream_ref
cec2e5f 
Fixes: NVIDIA#4150
bernhardmgruber added a commit that referenced this issue Mar 21, 2025
@bernhardmgruber @miscco
Allow cuda::par*.on() to take cuda::stream_ref (#4225)
45cb0b2 
Also drop `__host__ __device__` for stream_ref constructor

Fixes: #4150

Co-authored-by: Michael Schellenberger Costa <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow cuda::par*.on() to take cuda::stream_ref bernhardmgruber/cccl
1 participant
@brycelelbach