sample thcovmat only for L2 data, not L1 #2280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do a closure test of alphas determinations with the TCM we want to sample the theory covmat in the generation of L2 data, but not in the generation of L1 data. So there should be a separate key to activate sampling in the latter rather than using
use_thcovmat_in_samplingto decide wether the covmat should be used both at L1 and L2.Having said that, there are plans to also include MHOUs in a closure test which would complicate things since then we want to use the MHOU covmat in the L1 sampling but not the alphas covmat. Not sure how this can be done somewhat elegantly...