Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:transfer,tree,tree-select): rename CheckBox to Checkbox #8934

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

Laffery
Copy link
Collaborator

@Laffery Laffery commented Dec 14, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No
  • rename output property nzCheckBoxChange of NzTreeNode and NzTreeComponent to nzCheckboxChange
  • rename output property nzTreeCheckBoxChange of NzTreeSelectComponent to nzTreeCheckboxChange

All of these changes will be migrated by ng update

Other information

Copy link

zorro-bot bot commented Dec 14, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (82b660a) to head (ca677c7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8934   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         554      554           
  Lines       19683    19683           
  Branches     2937     2937           
=======================================
  Hits        18093    18093           
  Misses       1265     1265           
  Partials      325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery added Component: Tree 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes Component: TreeSelect PR: unreviewed PR: target-major labels Dec 14, 2024
@Laffery Laffery added this to the v19 milestone Dec 14, 2024
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119 HyperLife1119 merged commit c76433d into NG-ZORRO:master Dec 15, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants