Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token loading issues with non-compliant tokens #3926

Merged
merged 2 commits into from
Apr 9, 2021

Conversation

Mrtenz
Copy link
Collaborator

@Mrtenz Mrtenz commented Apr 8, 2021

This should fix any token loading issues, and a batch size of 300 should now work.

Both token loading and memberships should be tested before merging.

@Mrtenz Mrtenz requested a review from FrederikBolding April 8, 2021 13:58
@Mrtenz Mrtenz temporarily deployed to STAGING April 8, 2021 13:58 Inactive
@mycrypto-bot
Copy link
Collaborator

Staging build: MyCryptoBuilds

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #3926 (0025908) into master (00e292c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3926      +/-   ##
==========================================
+ Coverage   66.14%   66.21%   +0.06%     
==========================================
  Files         585      585              
  Lines       12248    12258      +10     
  Branches     3096     3099       +3     
==========================================
+ Hits         8102     8117      +15     
+ Misses       4115     4109       -6     
- Partials       31       32       +1     
Impacted Files Coverage Δ
src/config/constants.ts 100.00% <100.00%> (ø)
src/components/TimeCountdown.tsx 88.88% <0.00%> (-11.12%) ⬇️
src/services/Store/BalanceService.tsx 71.55% <0.00%> (-10.10%) ⬇️
src/services/Store/helpers.tsx 91.30% <0.00%> (-8.70%) ⬇️
...tectTransaction/components/ProtectTxProtection.tsx 49.18% <0.00%> (-0.82%) ⬇️
src/services/Store/StoreProvider.tsx 38.02% <0.00%> (-0.27%) ⬇️
src/utils/date.ts 92.10% <0.00%> (ø)
src/components/Amount.tsx 100.00% <0.00%> (ø)
src/services/TxHistory/useTxHistory.tsx 100.00% <0.00%> (ø)
src/features/SwapAssets/components/SwapQuote.tsx 66.66% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e292c...0025908. Read the comment docs.

@FrederikBolding FrederikBolding merged commit a44361c into master Apr 9, 2021
@FrederikBolding FrederikBolding deleted the mz/fix-token-issues branch April 9, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants