Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch read length info for run instead of just lane 1 #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kjellinjonas
Copy link

@kjellinjonas kjellinjonas commented Mar 17, 2025

Description:

Previously, get_metadata.py reported the read and index length based on the information from lane 1 which could be misleading in some cases. Therefore, it was decided that the script should be updated so that it shows the read length setting for the run instead.
In this update, this is achieved by fetching length information from RunInfo.xml

Also updated actions/cache from v2 --> v4.2.2 to enable automatic testing

Risk analysis:

The scripts will most likely fail if there are updates to the structure of the RunInfo.xml file. However, the damage from this would be minimal and should be noticed immediately.

Validation procedure:

Run ngi work flow, generate reports and makes sure that the expected read and index lengths are printed in the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant