Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22429] Prefer if_exists=... over mode=... #354

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 13, 2025

Change Summary

Due to pydantic/pydantic#5893, VSCode prefers alias over original field name:
Снимок экрана_20250313_173231
Снимок экрана_20250313_174013

But in some places we use alias=... for legacy field name, and original field name should be preferred:
Снимок экрана_20250313_172725
Снимок экрана_20250313_174041

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (179bf5c) to head (4f35d5f).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #354      +/-   ##
===========================================
+ Coverage    92.50%   92.51%   +0.01%     
===========================================
  Files          228      229       +1     
  Lines         9918     9932      +14     
  Branches      1014     1014              
===========================================
+ Hits          9175     9189      +14     
  Misses         557      557              
  Partials       186      186              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review March 13, 2025 15:02
@dolfinus dolfinus force-pushed the feature/DOP-22429-prefere-new-field-names branch from 7112895 to 4f35d5f Compare March 14, 2025 10:51
@dolfinus dolfinus enabled auto-merge (rebase) March 14, 2025 10:51
@dolfinus dolfinus merged commit 86fdd00 into develop Mar 14, 2025
52 checks passed
@dolfinus dolfinus deleted the feature/DOP-22429-prefere-new-field-names branch March 14, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants