Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22429] Prefer ipc_port and webhdfs_port instead alias #353

Closed
wants to merge 1 commit into from

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 13, 2025

Change Summary

SparkHDFS and HDFS have different port numbers, and this is denoted by having different field names ipc_port vs webhdfs_port.

But now both Sphinx and VSCode prefer using alias port instead of original field name:
Снимок экрана_20250313_174013
Снимок экрана_20250313_173934

Fixed:
Снимок экрана_20250313_174041
Снимок экрана_20250313_173913

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (05fb290) to head (9346736).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #353      +/-   ##
===========================================
+ Coverage    92.19%   92.50%   +0.31%     
===========================================
  Files          228      228              
  Lines         9918     9918              
  Branches      1014     1014              
===========================================
+ Hits          9144     9175      +31     
+ Misses         580      557      -23     
+ Partials       194      186       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus closed this Mar 13, 2025
@dolfinus dolfinus deleted the feature/DOP-22429-hdfs-port-alias branch March 13, 2025 14:44
@dolfinus
Copy link
Member Author

This is breaking, avoid making such changes in minor version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant