Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-22429] Prefer camelCase for Spark JDBC params #352

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Mar 13, 2025

Change Summary

There is a difference between onETL-only fields(if_exists, partitioning_mode) and Spark-only fields (partitionColumn, numPartitions). Highlight this difference by using camelCase for Spark, and snake_case for onETL.

camelCase aliases are already preferred by IDE:
Снимок экрана_20250313_172725

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Mar 13, 2025
@dolfinus dolfinus force-pushed the feature/DOP-22429-jdbcParams branch from b4b6d89 to 1d44631 Compare March 13, 2025 14:10
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (05fb290) to head (1d44631).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #352      +/-   ##
===========================================
+ Coverage    92.19%   92.50%   +0.31%     
===========================================
  Files          228      228              
  Lines         9918     9918              
  Branches      1014     1014              
===========================================
+ Hits          9144     9175      +31     
+ Misses         580      557      -23     
+ Partials       194      186       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus marked this pull request as ready for review March 13, 2025 14:50
@dolfinus dolfinus merged commit 179bf5c into develop Mar 14, 2025
44 checks passed
@dolfinus dolfinus deleted the feature/DOP-22429-jdbcParams branch March 14, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants