Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ellmer as backend for chat addin #248

Merged
merged 29 commits into from
Mar 26, 2025
Merged

Use ellmer as backend for chat addin #248

merged 29 commits into from
Mar 26, 2025

Conversation

calderonsamuel
Copy link
Collaborator

@calderonsamuel calderonsamuel commented Mar 23, 2025

Related issue

Description of changes

  • Migrated the logic for performing API requests to use {ellmer} as backend. #247
  • Added streaming support for all the currently supported providers (previously only available for OpenAI and Ollama). #221
  • The "Read docs" functionality now works for every Provider. #242
  • [INTERNAL] Added tests for the chat() wrapper on every migrated provider (missing azure_openai). Also, updated several tests and snapshots.

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes

For reviewers

  • Changes meet the acceptance criteria of the related issue
  • The contribution follows style conventions and code of conduct
  • Branch passes automated testing
  • I have incremented the package version in the DESCRIPTION file before merging

@calderonsamuel
Copy link
Collaborator Author

@JamesHWade let me know if there is anything missing on the azure_openai implementation. We can treat documentation as a separate issue. Might be a great time to start a "release issue" for v1.0.0

@JamesHWade
Copy link
Collaborator

Yes. Let's create the v1.0.0 release issue!!! I still need to fix azure for some edge cases before we push to CRAN but it should work for most use cases.

@JamesHWade JamesHWade merged commit fbf8d3d into main Mar 26, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants