Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getproperty bugfix #45

Merged
merged 10 commits into from
Jun 10, 2023
Merged

getproperty bugfix #45

merged 10 commits into from
Jun 10, 2023

Conversation

MasonProtter
Copy link
Owner

unwrap was erroneously using getproperty in a way that could fail if a user overloaded it (ref https://julialang.zulipchat.com/#narrow/stream/137791-general/topic/SumTypes.2Ejl.20updates/near/365062131)

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #45 (ac744f4) into master (0cf9c82) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          360       360           
=========================================
  Hits           360       360           
Impacted Files Coverage Δ
src/compute_storage.jl 100.00% <100.00%> (ø)

@MasonProtter MasonProtter merged commit 879a908 into master Jun 10, 2023
@MasonProtter MasonProtter deleted the getproperty branch June 10, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant