elbepack: hdimg: enable passing environment variables to grub #432
Conversation
The update-grub2 script is customizable by passing environment variables; however, it was impossible to do so in Elbe. This commit enables passing environment variables to the update-grub2 script in addition to the additional parameters for install-grub. Every word containing an equal sign will be interpreted as an environment variable. Signed-off-by: Thomas Bonnefille <[email protected]>
Taumille
force-pushed
the
grub_env_var
branch
from
8f62b91 to
e044197
Compare
| @@ -154,6 +154,11 @@ def install(self, target, user_args): | |||
| if '/' not in self.fs: | |||
| return | |||
|
|
|||
| # Extract environnement variable from user_args | |||
| Installs grub on this harddisk. The text content will be split | ||
| between additional command line arguments given to Elbe's | ||
| grub-install call and environment variables will be given to | ||
| update-grub2. |
There was a problem hiding this comment.
This is a really bad interface. Also it only works for grub2.
There was a problem hiding this comment.
Yep, I'm aware that the interface is not really good but as update-grub can be fed with environment variable, I thought that it was a good idea to have this kind of feature.
| Installs grub on this harddisk. The text content will be split | ||
| between additional command line arguments given to Elbe's | ||
| grub-install call and environment variables will be given to | ||
| update-grub2. |
There was a problem hiding this comment.
For new features also create an entry in newsfragments/.
| Installs grub on this harddisk. The text content will be split | ||
| between additional command line arguments given to Elbe's | ||
| grub-install call and environment variables will be given to | ||
| update-grub2. |
There was a problem hiding this comment.
I am wondering if these parameters should be come from the ELBE XML in the first place.
If update-grub2 is executed again manually or from apt/dpkg hooks, the configuration is not used anymore.
Instead if the configuration is written to /etc/default/grub or /etc/default/grub.d/ in the target it would always be respected.
There was a problem hiding this comment.
In my opinion, the same thing can be said about the current situation where we can pass parameters to grub-install. The goal of having it in the XML is to easily setup a specific way of setting up grub2 without having to hack into the rootfs with an overlay.
However indeed the user interface is not the best here...
There was a problem hiding this comment.
The config files could also be written through finetuning. Then the contents are directly in the ELBE XML.
It will also handle grub updates in the field.
There was a problem hiding this comment.
Ok so do you think I should persevere on this PR or is using finetuning/overlay sufficient for advanced users ?
There was a problem hiding this comment.
If finetuning/overlay does indeed work for you I would do prefer sticking to it.
There was a problem hiding this comment.
Okay, it indeed work in that way but I feel like I'm hacking into the rootfs instead of using the features provided by update-grub.
But no problem :), I'll close this PR, thank you very much for your reviews !
The update-grub2 script is customizable by passing environment variables; however, it was impossible to do so in Elbe.
This commit enables passing environment variables to the update-grub2 script in addition to the additional parameters for install-grub.
Every word containing an equal sign will be interpreted as an environment variable.
This is particularly useful for example when you want to force Grub to use PARTUUID (mandatory when booting without an initramfs).