Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefix in nginx set_real_ip_from to only use private address range #248

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Nothing4You
Copy link
Contributor

No description provided.

@Nothing4You
Copy link
Contributor Author

If all private IPv4 RFC 1918 private IPs should be accepted then this could be extended to also take 10.0.0.0/8 and 192.168.0.0/16.

@codyro
Copy link
Collaborator

codyro commented Jul 1, 2024

If all private IPv4 RFC 1918 private IPs should be accepted then this could be extended to also take 10.0.0.0/8 and 192.168.0.0/16.

I believe Docker uses the 172.17.0.0/16 by default, which might explain why this was configured this way.

Podman uses 10.88.0.0/16 by default, so we should at least add that range as well, although I can see the argument for doing the full /8.

@dessalines dessalines requested a review from codyro July 2, 2024 13:23
@codyro codyro merged commit f3e4c76 into LemmyNet:main Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants