-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing ansible tags #236
Conversation
@codyro did most of the work with tags already in the Alma playbook, so I've re-used as much as I can 😄 |
Is there a reason we've gone so descriptive with these? ie; can you let us know how we'd want to use them?
If we have these tags we should also have some documentation on how to use them efficiently. Otherwise I can see people running into problems. I understand ssl/certbot/initial as users could skip that and that could help solve #189 but i'm not sure of the others. (We'll most likely accept it as it is, but if we can have some guidance on how we could utilise these tags that would be great) |
Regarding the playbook I made, I tend to do it for development reasons (which sometimes can be helpful in production). I don't think it's harmful to have, though. I used the It lets you ensure some tasks always run even when limiting them to a subset via |
I'll defer to @codyro 's recommendations on this one, but simpler is better. |
LemmyNet#238 added the installation of cron as dependency, but the merge of LemmyNet#236 accidentally inserted a tags section in the middle of the packages to be installed
Added tags to
lemmy.yml
andlemmy-almalinux.yml
. Hope they look fine, pls suggest if there's any that can be changed.Also, this will kinda sorta help with #189 because you can run something like
ansible-playbook lemmy.yml --skip-tags ssl
that will effectively bypass everything related to ssl in case you want to reuse existing certificates (or your setup is like mine where I test out the files within WSL/vagrant without a valid domain).Honestly speaking I wouldn't recommend running the playbook solely relying on tags at all unless you're extremely familiar with both the playbook and ansible, but it can be used for cases like I mentioned.
I don't think
uninstall.yml
needs tags because it completely works on user input so I didn't bother.