Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removal of forced become #178

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: Removal of forced become #178

merged 1 commit into from
Oct 4, 2023

Conversation

ticoombs
Copy link
Collaborator

@ticoombs ticoombs commented Oct 4, 2023

Issue

Now that we have a delegate: localhost having this line in our config forces sudo on localhost.

Solution

Remove this line so it is optional if people want to use --become in their deployments.
Our readme already has --become as this is also redundant

Removing become as it forces sudo on all servers including localhost
@ticoombs ticoombs changed the title fix: Removal of forced BecomeUpdate ansible.cfg fix: Removal of forced become Oct 4, 2023
@ticoombs ticoombs added this to the 1.2.0 milestone Oct 4, 2023
@ticoombs ticoombs self-assigned this Oct 4, 2023
@dessalines dessalines merged commit 6d610c9 into main Oct 4, 2023
codyro added a commit to codyro/lemmy-ansible that referenced this pull request Oct 12, 2023
dessalines pushed a commit that referenced this pull request Oct 13, 2023
…tasks (#188)

* Add ansible-core >= 2.11.0 requirement
- Adds assertion to gracefully fail instead of an error (ref #177)
- Add to README

* Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook
- Refs #178

* Adjust Ansible -> ansible-core
- Add `become: false` to assertion in `lemmy.yml`

* Adjust README verbiage

* Apparently I really want it to be 2.10.0
@ticoombs ticoombs deleted the ticoombs-patch-1 branch October 25, 2023 22:48
usr3 pushed a commit to usr3/futurology-lemmy that referenced this pull request Dec 23, 2023
…tasks (LemmyNet#188)

* Add ansible-core >= 2.11.0 requirement
- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177)
- Add to README

* Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook
- Refs LemmyNet#178

* Adjust Ansible -> ansible-core
- Add `become: false` to assertion in `lemmy.yml`

* Adjust README verbiage

* Apparently I really want it to be 2.10.0
snowe2010 pushed a commit to programming-dot-dev/lemmy-ansible that referenced this pull request Jan 30, 2024
Removing become as it forces sudo on all servers including localhost
snowe2010 pushed a commit to programming-dot-dev/lemmy-ansible that referenced this pull request Jan 30, 2024
…tasks (LemmyNet#188)

* Add ansible-core >= 2.11.0 requirement
- Adds assertion to gracefully fail instead of an error (ref LemmyNet#177)
- Add to README

* Remove `become` on `localhost` to `lemmy-almalinux.yml` playbook
- Refs LemmyNet#178

* Adjust Ansible -> ansible-core
- Add `become: false` to assertion in `lemmy.yml`

* Adjust README verbiage

* Apparently I really want it to be 2.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants