feat: pictrs-safety #175
Merged
feat: pictrs-safety #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
codyro
reviewed
Sep 23, 2023
4 tasks
dessalines
reviewed
Sep 26, 2023
dessalines
reviewed
Sep 26, 2023
ticoombs
requested changes
Sep 27, 2023
ticoombs
approved these changes
Sep 28, 2023
|
From a code standpoint it looks fine now. |
dessalines
approved these changes
Sep 28, 2023
|
Everything looks good/tested on the normal targets. At some point, we should consider showing an example of using SSL/TLS so the pictrs-safety<->worker data can be encrypted (image body is sent). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inventory variable to enable picts-safety
pictrs gets an extra conditional for a new variable
PICTRS__MEDIA__EXTERNAL_VALIDATIONto connect the validation to pictrs-safety.I used `{{ domain }} for it, as I don't know how otherwise to tell pictrs which IP to connect. Feel free to adjust to use some internal IP. My docker knowledge is very superficial.
Likewise, the pictrs-safety port is supposed to be exposed to the internet to allow workers to connect to it.
Currently I'm using the
:mainversion as I'm having trouble pushing versioned docker images to ghcr.io. I'm trying to figure that out.