Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA][Detox] Improve memory management #9615

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Mar 21, 2025

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox tests

📝 Description

Created global variables for element helpers, application pages and bridge server to help limit memory consumption

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
abdurrahman-ledger Abdurrahman Sastim

Verified

This commit was signed with the committer’s verified signature.
abdurrahman-ledger Abdurrahman Sastim

Verified

This commit was signed with the committer’s verified signature.
abdurrahman-ledger Abdurrahman Sastim
Copy link

vercel bot commented Mar 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 1:01pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 1:01pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 1:01pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2025 1:01pm

Verified

This commit was signed with the committer’s verified signature.
abdurrahman-ledger Abdurrahman Sastim
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Mar 26, 2025

Desktop Bundle Checks

Comparing 775841a against fb12125.

🚀 renderer bundle size decreased (40mb -> 39.7mb). Thanks ❤️
🚀 @noble/hashes/blake2b library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing 775841a against 706fe9d.

🚀 main.ios.jsbundle bundle size decreased (64.4mb -> 63.9mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (64.4mb -> 63.9mb). Thanks ❤️

@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review March 26, 2025 08:36
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners March 26, 2025 08:36

Verified

This commit was signed with the committer’s verified signature.
abdurrahman-ledger Abdurrahman Sastim
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_311_detox_memory-leak branch from 16b0c51 to ab1cb89 Compare March 26, 2025 13:00
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_311_2_detox_improvements branch 3 times, most recently from 542782a to eb0bbf1 Compare March 27, 2025 14:13
@abdurrahman-ledger
Copy link
Contributor Author

#9595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants