Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tokens to cal #29

Merged
merged 2 commits into from
Mar 26, 2025
Merged

Add missing tokens to cal #29

merged 2 commits into from
Mar 26, 2025

Conversation

may01
Copy link
Collaborator

@may01 may01 commented Mar 23, 2025

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.81%. Comparing base (67a2a90) to head (4505267).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #29   +/-   ##
========================================
  Coverage    43.81%   43.81%           
========================================
  Files            8        8           
  Lines          550      550           
  Branches       149      149           
========================================
  Hits           241      241           
  Misses         309      309           
Flag Coverage Δ
unittests 43.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@may01 may01 force-pushed the feat/add_cal_tokens branch from b70c9da to 58ea9c1 Compare March 23, 2025 19:51
Copy link
Collaborator

@joaoccmartins joaoccmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We can also remove 0x1:aptos_coin as well while we're here.

@may01
Copy link
Collaborator Author

may01 commented Mar 24, 2025

We can also remove 0x1:aptos_coin as well while we're here.

We still use it to clear sign the native currency.

@joaoccmartins
Copy link
Collaborator

We can also remove 0x1:aptos_coin as well while we're here.

We still use it to clear sign the native currency.

That's managed as a special case in common_display.c:420

@tdejoigny-ledger tdejoigny-ledger merged commit 3201efc into develop Mar 26, 2025
184 checks passed
@tdejoigny-ledger tdejoigny-ledger deleted the feat/add_cal_tokens branch March 26, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants