LibWeb: Use first font with space in range for first_available_computed_font
#3970
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
mkljczk
force-pushed
the
fix-font-metrics
branch
from
7ea3690 to
66a9a88
Compare
mkljczk
force-pushed
the
fix-font-metrics
branch
from
66a9a88 to
d4602c9
Compare
SimonDevScr
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I got this right. I adapted it from https://github.com/LadybirdBrowser/ladybird/blob/master/Libraries/LibWeb/Layout/Node.h#L335. Before this change, in my case a
chCSS unit relied on an Arabic font which explicitly didn't have a space in itsunicode-range, causing the result to be off compared to other browsers.