LibWeb/CSS: Implement background-blend-mode
#3940
Open
+318
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the regex for CSS URLs in the WPT import script to correctly match URLs surrounded by single quotes.
This implements the 'background-blend-mode' CSS property.
skyz1
force-pushed
the
background-blend-mode
branch
from
b94908a to
3287183
Compare
AtkinsSJ
requested changes
Mar 14, 2025
| @@ -327,6 +327,14 @@ | |||
| "background-attachment" | |||
| ] | |||
| }, | |||
| "background-blend-mode": { | |||
| "animation-type": "none", | |||
| @@ -452,6 +454,7 @@ class ComputedValues { | |||
| CSS::UserSelect user_select() const { return m_noninherited.user_select; } | |||
| CSS::Isolation isolation() const { return m_noninherited.isolation; } | |||
| CSS::Containment const& contain() const { return m_noninherited.contain; } | |||
| CSS::MixBlendMode background_blend_mode() const { return m_noninherited.background_blend_mode; } | |||
There was a problem hiding this comment.
Because the blend mode is stored as part of the BackgroundLayerData, we shouldn't store it on its own in ComputedValues as well.
Comment on lines
+1629
to
+1633
| MixBlendMode ComputedProperties::background_blend_mode() const | ||
| { | ||
| auto const& value = property(PropertyID::BackgroundBlendMode); | ||
| return keyword_to_mix_blend_mode(value.to_keyword()).release_value(); | ||
| } |
There was a problem hiding this comment.
Similarly, this is not needed as nobody will ask for a background-blend-mode on its own.
| @@ -24,6 +24,7 @@ struct ResolvedBackgroundLayerData { | |||
| CSSPixelRect image_rect; | |||
| CSS::Repeat repeat_x; | |||
| CSS::Repeat repeat_y; | |||
| CSS::MixBlendMode mix_blend_mode; | |||
There was a problem hiding this comment.
Nit: Just call this blend_mode. Looks like <blend-mode> is the type name used in the spec currently.
| @@ -100,6 +100,7 @@ struct DrawRepeatedImmutableBitmap { | |||
| }; | |||
|
|
|||
| struct Save { }; | |||
| struct SaveLayer { }; | |||
There was a problem hiding this comment.
Ideally, adding the SaveLayer command would be in its own commit before this one.
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
github-actions
bot
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
background-blend-modeCSS property and fixes a regex in the WPT import script that caused the import of the corresponding test to fail.Some of the blending modes in LibGFX do not exactly reflect the behavior of the other browsers. However, this issue is outside the scope of this PR, which focuses on applying the appropriate blending modes to the backgrounds.