RequestServer: Don't assert for socket fd not being CURL_SOCKET_BAD #3930
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion in `WebSocketImplCurl::did_connect()` keeps failing for multiple websockets when loading `https://www.speedtest.net/` since commit 14ebcd4. This fixes that by checking and returning false if something went wrong and letting the caller function handle it. Issue: LadybirdBrowser#3828
mobounya
force-pushed
the
ws_curl_handle_bad_socket
branch
from
b0e72fa to
78a25da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertion in
WebSocketImplCurl::did_connect()keeps failing for multiple websockets when loadinghttps://www.speedtest.net/since commit 14ebcd4. This fixes that by checking and returning false if something went wrong and letting the caller function handle it.Fixes: #3828