Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Skip the svg-inline-sizing/svg-inline.html WPT test for now #3912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sideshowbarker
Copy link
Contributor

@sideshowbarker sideshowbarker commented Mar 12, 2025

See #3911. The html/rendering/replaced-elements/svg-inline-sizing/svg-inline.html WPT test is causing a hang/timeout that prevents being able to run the test suite to completion with Debug builds.

@sideshowbarker sideshowbarker force-pushed the svg-inline-sizing_svg-inline.html branch from e7b636e to e9ccf09 Compare March 13, 2025 12:12
Copy link

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Mar 13, 2025
@sideshowbarker sideshowbarker force-pushed the svg-inline-sizing_svg-inline.html branch from e9ccf09 to eabb26a Compare March 17, 2025 04:36
@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Mar 17, 2025
@sideshowbarker sideshowbarker changed the title Tests: Skip the svg-inline-sizing/svg-inline.html for now Tests: Skip the svg-inline-sizing/svg-inline.html WPT test for now Mar 17, 2025
@sideshowbarker
Copy link
Contributor Author

Without this change, running ./Meta/ladybird.sh run headless-browser --run-tests "./Tests/LibWeb" is still timing out for me on the master branch. I don’t understand why it’s not also causing other PRs to fail…

@sideshowbarker
Copy link
Contributor Author

And now noticing that I can’t reproduce the timeout for this test with a Release build. It only happens with a Debug build.

See LadybirdBrowser#3911. The
html/rendering/replaced-elements/svg-inline-sizing/svg-inline.html WPT
test is causing a hang/timeout that prevents being able to run the test
suite to completion.
@sideshowbarker sideshowbarker force-pushed the svg-inline-sizing_svg-inline.html branch from eabb26a to 2f41ad2 Compare March 17, 2025 06:09
@sideshowbarker
Copy link
Contributor Author

All green here now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant