Tests: Add a bunch of input-element tests (tests only, no code) #3866
+2,024
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
force-pushed
the
tests-add-the-input-element
branch
8 times, most recently
from
7eb58b4 to
8b3ce5a
Compare
|
All these tests (and all other tests) are passing when I run the test suite locally. I am hitting the VERIFICATION FAILED: root_element->layout_node() at /Users/mike/workspace/ladybird/Libraries/LibWeb/CSS/Length.cpp:157 thing locally, but that seems to happen after all the tests have been run successfully (except for the one timeout) |
sideshowbarker
force-pushed
the
tests-add-the-input-element
branch
3 times, most recently
from
742b5ae to
cef22dd
Compare
Importing these tests now because they are for input-element types that have requirements related to the constraint-validation API — which we’ve been implementing recently. This commit only imports tests, without any changes to our code.
sideshowbarker
force-pushed
the
tests-add-the-input-element
branch
from
cef22dd to
c8a2a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing these tests now because they are for input-element types that have requirements related to the constraint-validation API — which we’ve been implementing recently.
This commit only imports tests, without any changes to our code.