LibURL/Pattern: Implement processing a URL Pattern Init #3847
+4,009
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
shannonbooth
force-pushed
the
urlpatter-init
branch
from
7e0f8fc to
81b8466
Compare
github-actions
bot
removed
the
conflicts
shannonbooth
force-pushed
the
urlpatter-init
branch
2 times, most recently
from
21e32a2 to
c84e4aa
Compare
This follows a rename made in the URL specification.
This gets us to the point just before the point of parsing the pattern strings for each URL component to produce a regular expression.
shannonbooth
force-pushed
the
urlpatter-init
branch
from
c84e4aa to
9b12c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small batch of commits upstreaming from my fork, along from a WPT import of the primary URLPattern test as we're getting close-ish to a full implementation now :^)