fix: Handle wildcard rootHost values #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where if you specify a wildcard rootHost value e.g. *.example.com the plan would incorrectly filter out changes for valid dnsNames e.g. foo.example.com, and only create exactly matching dnsNames e.g. *.example.com.
mikenairn
commented
Apr 22, 2024
| "RecordTTL": Equal(externaldnsendpoint.TTL(60)), | ||
| })), | ||
| )) | ||
| }) |
There was a problem hiding this comment.
We have no way of verifying this from the integration test at the moment. Added e2e test for the time being.
mikenairn
commented
Apr 22, 2024
| @@ -301,7 +301,7 @@ func (r *DNSRecordReconciler) applyChanges(ctx context.Context, dnsRecord *v1alp | |||
| logger := log.FromContext(ctx) | |||
| filterDomain, _ := strings.CutPrefix(managedZone.Spec.DomainName, v1alpha1.WildcardPrefix) | |||
| if dnsRecord.Spec.RootHost != nil { | |||
| filterDomain = *dnsRecord.Spec.RootHost | |||
| filterDomain, _ = strings.CutPrefix(*dnsRecord.Spec.RootHost, v1alpha1.WildcardPrefix) | |||
There was a problem hiding this comment.
We might want to consider adding validation onto the rootHost CRD field.
maleck13
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #88
Fixes an issue where if you specify a wildcard rootHost value e.g. *.example.com the plan would incorrectly filter out changes for valid dnsNames e.g. foo.example.com, and only create exactly matching dnsNames e.g. *.example.com.
Follow on to look at making sure the status is always correctly updated #90