Fix for #317 and probably #324 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it's probably fine to just catch all exceptions here and write them to
log. There isn't anything that can be done about these other than ignore
the folder and move on. That way it would also handle any security
exceptions that might happen.
…On Fri, Nov 26, 2021 at 1:28 PM 102464 ***@***.***> wrote:
A solution for #317
<#317> and
probably #324
<#324>
------------------------------
You can view, comment on, or merge this pull request online at:
#330
Commit Summary
- f72c472
<f72c472>
Fix for unhandled ArgumentException
File Changes
(1 file <https://github.com/Klocman/Bulk-Crap-Uninstaller/pull/330/files>)
- *M* source/UninstallTools/Factory/DirectoryFactory.cs
<https://github.com/Klocman/Bulk-Crap-Uninstaller/pull/330/files#diff-54e808b37098425894ad741bcf3efbebabe62e51387a4843a9abd9f924ecebe8>
(5)
Patch Links:
- https://github.com/Klocman/Bulk-Crap-Uninstaller/pull/330.patch
- https://github.com/Klocman/Bulk-Crap-Uninstaller/pull/330.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#330>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRZC4GJ455WHTL7F7DPT7TUN54PZANCNFSM5I2RZV4Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I changed it to catch and log all exceptions just to be sure. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for #317 and probably #324