Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UUID extended to conform to Identifier #47

Merged
merged 4 commits into from
Sep 24, 2019
Merged

UUID extended to conform to Identifier #47

merged 4 commits into from
Sep 24, 2019

Conversation

mcritz
Copy link
Contributor

@mcritz mcritz commented Sep 17, 2019

Addresses #46

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dillan
Copy link

dillan commented Sep 19, 2019 •
edited
Loading

@mcritz Thanks for doing this. Hopefully it is merged in soon. I'll be using it in one of my projects.

djones6
djones6 reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@djones6 djones6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. One small nit-pick:

@djones6 djones6 merged commit 47d30e9 into Kitura:master Sep 24, 2019
@mcritz mcritz deleted the uuid-identifier branch September 24, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djones6 djones6 djones6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcritz @CLAassistant @dillan @djones6