Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Added π120U30 and π120U31 #2938

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Added π120U30 and π120U31 #2938

merged 2 commits into from
Aug 31, 2020

Conversation

G-Pereira
Copy link
Contributor

@G-Pereira G-Pereira commented Aug 27, 2020

Alias for this two digital isolators.
Datasheet

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue
Copy link
Contributor

Guess this had to happen... there was a discussion about manufacturers' sanity just yesterday...

@stambaughw @sethhillbrand are there still reasons not to include multibyte chars in symbol names or do you believe it's safe?

@G-Pereira how about calling them τ/2?

@sethhillbrand
Copy link

U+0C30 is in our standard font, so it should be no problem.

@aris-kimi
Copy link
Collaborator

I want to suggest to add a translated version of MPN at the keyword field as pi120u30/1. I think this might ease the search process.

@G-Pereira
Copy link
Contributor Author

I want to suggest to add a translated version of MPN at the keyword field as pi120u30/1. I think this might ease the search process.

I was about to suggest the same

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 27, 2020
@aris-kimi
Copy link
Collaborator

@G-Pereira one last change, parent symbol's name offset i think it is good to change to 20mil / 0.508mm

@G-Pereira
Copy link
Contributor Author

Hi, I already fixed that on a separate PR that already has been merged, check #2939

@G-Pereira
Copy link
Contributor Author

@aris-kimi and @chschlue is this ready to merge?

@chschlue chschlue self-assigned this Aug 31, 2020
@chschlue chschlue removed the Pending reviewer A pull request waiting for a reviewer label Aug 31, 2020
Copy link
Contributor

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants