Don't leak PerfBench in @measure
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zentrik
approved these changes
Sep 13, 2024
topolarity
force-pushed
the
ct/fix-leak
branch
from
96731f8 to
5c7d6a1
Compare
It's important not to leak these perf events, due to limited PMU resources on the system. Without this fix, running the two README examples back-to-back on my system leads to: ``` ┌ Warning: Some events are not measured └ @ LinuxPerf ~/.julia/dev/LinuxPerf/src/LinuxPerf.jl:892 ... ┌ instructions NA 0.0% └ branch-misses NA 0.0% ```
topolarity
force-pushed
the
ct/fix-leak
branch
from
5c7d6a1 to
2cc5daa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important not to leak these perf events, due to limited PMU resources on the system.
Without this fix, running the two README examples back-to-back on my system leads to: