Feature/images refactor #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhayes777
approved these changes
Feb 21, 2025
Comment on lines
+389
to
+391
| galaxy_plotter.figures_1d_decomposed(image=True) | ||
| galaxy_plotter.figures_1d_decomposed(convergence=True) | ||
| galaxy_plotter.figures_1d_decomposed(potential=True) |
There was a problem hiding this comment.
Often passing a boolean to a function like this is a code smell indicating that you should have multiple separate functions instead
| "normalized_residual_map", | ||
| "chi_squared_map", | ||
| ], | ||
| # tag_list=[name for name, galaxy in galaxies.items()], |
| multi_plotter.output_to_fits( | ||
| func_name_list=["figure_2d"] * len(multi_plotter.plotter_list), | ||
| figure_name_list=[None] * len(multi_plotter.plotter_list), | ||
| # tag_list=[name for name, galaxy in galaxies.items()], |
| ) | ||
|
|
||
| multi_plotter.output_to_fits( | ||
| func_name_list=["figure_2d"] * len(multi_plotter.plotter_list), |
There was a problem hiding this comment.
Assign len(multi_plotter.plotter_list) to a variable to avoid repetition
|
|
||
| multi_plotter.output_to_fits( | ||
| func_name_list=["figure_2d"] * len(multi_plotter.plotter_list), | ||
| figure_name_list=[None] * len(multi_plotter.plotter_list), |
There was a problem hiding this comment.
Assign len(multi_plotter.plotter_list) to a variable to avoid repetition
| # | ||
| # multi_plotter.output_to_fits( | ||
| # func_name_list=["figures_2d"] * len(multi_plotter.plotter_list), | ||
| # figure_name_list=[ |
| "dirty_normalized_residual_map", | ||
| "dirty_chi_squared_map", | ||
| ], | ||
| # tag_list=[name for name, galaxy in galaxies.items()], |
| # ) | ||
| # | ||
| # assert visibilities.shape == (5, 5) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors image output such that:
Removes config customization on the level of individual figures, as this made configs too complex and can be achieved via
AggretorImages.Outputs .fits files containing key images as .fits output of key information is key, with these grouped packages suited to
AggregatorFitsobject.Creates a nasty new function in
MultiFigurePlotterfor outputting .fits groups viaPlotterinterface, quite hacky but works for now.