Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console.error left over in the code? #75

Closed
jcompagner opened this issue Aug 21, 2024 · 2 comments
Closed

console.error left over in the code? #75

jcompagner opened this issue Aug 21, 2024 · 2 comments

Comments

@jcompagner
Copy link
Contributor

this commit
083f662#diff-9e1a27ae206cc88f0235003fbfc84b563f72997c07ab3a6f9c26817b0f3f6f99R987

adds that console.error message: https://github.com/Harvest-Dev/ng-select2/blob/master/projects/ng-select2-component/src/lib/select2.component.ts#L1007
is that really a thing you want to report? (then i guess the message should be more clear)
or is that really a left over from some debugging?

jcompagner added a commit to Servoy/servoy-eclipse that referenced this issue Aug 21, 2024
i think this is a left over console error log (for debugging):
Harvest-Dev/ng-select2#75

but the thing is that we do get a model update push before we really
show the form, but then the form is first shown with the old data and
then we update the cache (and notify the components)
this is a bit wird, if there is a form cache already (so there is data
for that form)
@Zefling
Copy link
Collaborator

Zefling commented Aug 21, 2024

Indeed, this is a debugging oversight.
I will remove this.

Zefling added a commit that referenced this issue Aug 21, 2024
@Zefling
Copy link
Collaborator

Zefling commented Aug 21, 2024

Fix in 15.2.1

@Zefling Zefling closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants