Remove unused vars #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinbb
requested changes
Feb 5, 2025
| @@ -19,16 +19,10 @@ let | |||
| secretsImportScript = pkgs.writeScript "secrets-import" '' | |||
| #! /bin/sh | |||
| set -eu | |||
| NETLIFY_AUTH_TOKEN="$(cat /run/keys/netlify-auth-token)" | |||
There was a problem hiding this comment.
Note that the 'prod' build server also builds and deploys other Granola repos besides 'mina-indexer'. They require this Netlify token.
| CLOUDFLARE_ACCOUNT_ID="$(cat /run/keys/cloudflare-account-id)" | ||
| export CLOUDFLARE_ACCOUNT_ID | ||
| CLOUDFLARE_API_TOKEN="$(cat /run/keys/cloudflare-api-token)" | ||
| export CLOUDFLARE_API_TOKEN | ||
| LINODE_OBJ_ACCESS_KEY="$(cat /run/keys/linode-access-key)" |
There was a problem hiding this comment.
These keys should be left on the box because we may want to build (rollback) to a build that requires the Linode object store.
| chown bk:keys /run/keys/cloudflare-account-id && | ||
| chown bk:keys /run/keys/cloudflare-api-token && | ||
| chown bk:keys /run/keys/linode-access-key && | ||
| chown bk:keys /run/keys/linode-secret-key && | ||
| chmod 0400 /run/keys/buildkite-agent-token && |
There was a problem hiding this comment.
This line was probably an accidental deletion.
|
These changes have in fact not been made on the machines. It sounds like we should just leave these variables intact; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove outdated/unused variables