Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds SampledDimension axis overload #504

Closed
wants to merge 1 commit into from
Closed

Conversation

jgrewe
Copy link
Member

@jgrewe jgrewe commented Jun 13, 2021

with this it is possible to specifiy a start position, not only a start index

start index takes precedence over start position to maintain old behaviour. added some value checking too.

@coveralls
Copy link

coveralls commented Jun 13, 2021

Coverage Status

Coverage increased (+0.01%) to 79.037% when pulling 666697a on jgrewe:axis into 130fab2 on G-Node:master.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #504 (666697a) into master (130fab2) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   78.76%   78.77%   +0.01%     
==========================================
  Files          59       59              
  Lines        9342     9356      +14     
==========================================
+ Hits         7358     7370      +12     
- Misses       1984     1986       +2     
Impacted Files Coverage Δ
nixio/test/test_dimensions.py 99.52% <87.50%> (-0.24%) ⬇️
nixio/dimensions.py 91.32% <90.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130fab2...666697a. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 13, 2021

This pull request introduces 1 alert when merging 866331f into 8dcb254 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@jgrewe
Copy link
Member Author

jgrewe commented Jun 20, 2021

closing and reopening this to see what happens to appveyor...

@jgrewe jgrewe closed this Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants